From: Christoph Hellwig <hch@lst.de>
To: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: only call ->done once all per-tag ressources are released
Date: Mon, 5 Oct 2015 08:01:17 +0200 [thread overview]
Message-ID: <20151005060117.GA2294@lst.de> (raw)
In-Reply-To: <20151004173429.GD19652@htj.duckdns.org>
On Sun, Oct 04, 2015 at 01:34:29PM -0400, Tejun Heo wrote:
> Hmmm... has this actually been observed? All these are run under ata
> port lock and so is the command issue path, so even if the tag gets
> reissued, it will have to wait till the completion path is done.
No - I stumbled over this while trying to debug
https://lkml.org/lkml/2015/6/25/620 (which could use some libata experience,
btw), but it didn't help. I still would like to see it fixes as similar
patterns in SCSI drivers have caused crashes.
next prev parent reply other threads:[~2015-10-05 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 17:21 libata: a fix and a cleanup Christoph Hellwig
2015-10-03 17:21 ` [PATCH 1/2] libata: only call ->done once all per-tag ressources are released Christoph Hellwig
2015-10-04 17:34 ` Tejun Heo
2015-10-05 6:01 ` Christoph Hellwig [this message]
2015-10-06 17:28 ` Tejun Heo
2015-10-08 8:25 ` [PATCH 1/2 v2] " Christoph Hellwig
2015-10-12 16:23 ` Tejun Heo
2015-10-03 17:21 ` [PATCH 2/2] libata: cleanup ata_scsi_qc_complete Christoph Hellwig
2015-10-04 17:39 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005060117.GA2294@lst.de \
--to=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).