Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Vinayak Kale <vinayak.kale@seagate.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	Vinayak Kale <vinayak.kale@gmail.com>,
	sumit.g.gupta@seagate.com
Subject: Re: [PATCH] libata: add support for NCQ commands for SG interface
Date: Fri, 23 Oct 2015 14:39:45 +0900	[thread overview]
Message-ID: <20151023053945.GA24618@mtj.duckdns.org> (raw)
In-Reply-To: <CAAtun4jvUaVsGSofq5n-sJzmSf4qBsPvQ7WU6dOik4JYSMnZNw@mail.gmail.com>

Hello,

On Fri, Oct 23, 2015 at 10:01:35AM +0530, Vinayak Kale wrote:
> > It looks like it'd work given that it's forcing qc->tag into
> > tf->nsect.  What's the use case tho?
> 
> We need to issue NCQ commands with priority bit from user space application.
> 
> BTW, Sergei Shtylyov raised concern regarding usefulness of adding
> ATA_TFLAG_LBA to tf->flags. Can you please comment on that as well?
> Accordingly I will either keep it or discard it in V2. Thanks.

I like the change but can you please put that in a separate patch?
Also, can you please verify that this works fine with multiple regular
NCQ commands in flight?

Thanks.

-- 
tejun

  parent reply	other threads:[~2015-10-23  5:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-17 11:48 [PATCH] libata: add support for NCQ commands for SG interface vinayak.kale
2015-10-17 12:00 ` Sergei Shtylyov
2015-10-17 12:25   ` Vinayak Kale
2015-10-17 18:42     ` Sergei Shtylyov
2015-10-19  6:55       ` Vinayak Kale
2015-10-21  5:09 ` Vinayak Kale
2015-10-22  8:57   ` Tejun Heo
     [not found]     ` <CAAtun4jvUaVsGSofq5n-sJzmSf4qBsPvQ7WU6dOik4JYSMnZNw@mail.gmail.com>
2015-10-23  5:39       ` Tejun Heo [this message]
2015-10-23 20:08         ` Vinayak Kale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151023053945.GA24618@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sumit.g.gupta@seagate.com \
    --cc=vinayak.kale@gmail.com \
    --cc=vinayak.kale@seagate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox