Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ahci per-port msix support
Date: Tue, 3 Nov 2015 17:32:20 -0500	[thread overview]
Message-ID: <20151103223220.GF5749@mtj.duckdns.org> (raw)
In-Reply-To: <20151102192302.GD9553@mtj.duckdns.org>

On Mon, Nov 02, 2015 at 02:23:02PM -0500, Tejun Heo wrote:
> On Sun, Nov 01, 2015 at 01:43:35PM -0500, Dan Williams wrote:
> > Changes since v1 [1]:
> > 
> > 1/ Clean up "nvec = min(nvec, n_ports);" statement (Tejun)
> > 
> > 2/ Drop threaded interrupt handling option for now.
> > 
> > [1]: http://marc.info/?l=linux-ide&m=144623970817213&w=2
> 
> Applied to libata/for-4.4.

Dan, I got the following build failures from kbuild and reverted the
two patches from for-4.4.  It's too late for this merge window anyway.
Let's try the next one.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/libata for-4.4
head:   3758b0e5028c4b5083f2148ddc06b719d73e7627
commit: 6cb1c51aa65039ab3860c9741f9a190b7ab199cb [19/20] ahci: per-port msix support
config: mips-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 6cb1c51aa65039ab3860c9741f9a190b7ab199cb
        # save the attached .config to linux build tree
        make.cross ARCH=mips

All errors (new ones prefixed by >>):

   drivers/ata/libahci.c: In function 'ahci_host_activate_multi_irqs':
>> drivers/ata/libahci.c:2492:4: error: invalid use of undefined type 'struct msix_entry'
       irq = hpriv->msix[i].vector;
       ^
>> drivers/ata/libahci.c:2492:21: error: dereferencing pointer to incomplete type 'struct msix_entry'
       irq = hpriv->msix[i].vector;
                        ^

vim +2492 drivers/ata/libahci.c

  2486           */
  2487          for (i = 0; i < host->n_ports; i++) {
  2488                  struct ahci_port_priv *pp = host->ports[i]->private_data;
  2489                  int irq;
  2490
  2491                  if (hpriv->flags & AHCI_HFLAG_MULTI_MSIX)
> 2492                          irq = hpriv->msix[i].vector;
  2493                  else
  2494                          irq = hpriv->irq + i;
  2495

-- 
tejun

  reply	other threads:[~2015-11-03 22:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-01 18:43 [PATCH v2 0/2] ahci per-port msix support Dan Williams
2015-11-01 18:43 ` [PATCH v2 1/2] ahci: " Dan Williams
2015-11-01 18:43 ` [PATCH v2 2/2] ahci: switch from 'threaded' to 'hardirq' interrupt handling Dan Williams
2015-11-02 19:23 ` [PATCH v2 0/2] ahci per-port msix support Tejun Heo
2015-11-03 22:32   ` Tejun Heo [this message]
2015-11-03 22:35     ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151103223220.GF5749@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox