From: Tejun Heo <tj@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: core: fix irq description on AHCI single irq systems
Date: Mon, 7 Dec 2015 09:48:06 -0500 [thread overview]
Message-ID: <20151207144806.GA9175@mtj.duckdns.org> (raw)
In-Reply-To: <5664A101.1050401@gmail.com>
On Sun, Dec 06, 2015 at 09:56:33PM +0100, Heiner Kallweit wrote:
> On my machine with single irq AHCI just the PCI id is printed as
> description in /proc/interrupts.
> I found a related discussion from beginning of this year:
> http://www.gossamer-threads.com/lists/linux/kernel/2117335
>
> Seems like commit commit 4f37b504768c952b64bc9469a2d579c7597590f2
> tried to fix displaying a proper interrupt description for one
> scenario but broke it for another one.
>
> The mentioned discussion ended in the current situation being
> considered as broken but w/o a patch to fix it.
>
> The following patch is based on a proposal in this mail thread.
> Now the interrupt is properly described as:
> PCI-MSI 512000-edge ahci[0000:00:1f.2]
>
> By combining both values also the scenario that commit
> 4f37b504768c952b64bc9469a2d579c7597590f2 refers to should
> still be fine. There it should look like this now:
> ahci[20100000.ide]
>
> Using managed memory allocation ensures that the irq description
> lives at least as long as the interrupt.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to libata/for-4.5 w/ commit refs fixed.
Thanks.
--
tejun
prev parent reply other threads:[~2015-12-07 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 20:56 [PATCH] ata: core: fix irq description on AHCI single irq systems Heiner Kallweit
2015-12-07 11:00 ` Sergei Shtylyov
2015-12-07 14:48 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207144806.GA9175@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox