From: Tejun Heo <tj@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: linux-ide@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] libata: disable forced PORTS_IMPL for >= v3.0 controllers
Date: Thu, 14 Jan 2016 17:37:32 -0500 [thread overview]
Message-ID: <20160114223732.GG3520@mtj.duckdns.org> (raw)
In-Reply-To: <CALCETrU7yMvXEDhjAUShoHEhDwifJGapdw--BKxsP0jmjKGmRw@mail.gmail.com>
Some early controllers incorrectly reported zero ports in PORTS_IMPL
register and the ahci driver fabricates PORTS_IMPL from the number of
ports in those cases. This hasn't mattered but with the new nvme
controllers there are cases where zero PORTS_IMPL is valid and should
be honored.
Disable the workaround for controllers >= v3.0.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Andy Lutomirski <luto@amacapital.net>
Link: http://lkml.kernel.org/g/CALCETrU7yMvXEDhjAUShoHEhDwifJGapdw--BKxsP0jmjKGmRw@mail.gmail.com
---
Hello, Andy.
Can you please test whether this fixes the issue?
Thanks.
drivers/ata/libahci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index d61740e..4931075 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -496,8 +496,8 @@ void ahci_save_initial_config(struct device *dev, struct ahci_host_priv *hpriv)
}
}
- /* fabricate port_map from cap.nr_ports */
- if (!port_map) {
+ /* fabricate port_map from cap.nr_ports for older controllers */
+ if (!port_map && (vers >> 16) <= 2) {
port_map = (1 << ahci_nr_ports(cap)) - 1;
dev_warn(dev, "forcing PORTS_IMPL to 0x%x\n", port_map);
next prev parent reply other threads:[~2016-01-14 22:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 6:51 Unhappy ahci controller on Dell XPS 13 9350 Andy Lutomirski
2016-01-14 22:16 ` Tejun Heo
2016-01-14 22:37 ` Tejun Heo [this message]
2016-01-15 1:00 ` [PATCH] libata: disable forced PORTS_IMPL for >= v3.0 controllers Andy Lutomirski
2016-01-15 19:48 ` Tejun Heo
2016-01-15 20:13 ` [PATCH v2] libata: disable forced PORTS_IMPL for >= AHCI 1.3 Tejun Heo
2016-01-15 22:49 ` Andy Lutomirski
2016-01-16 10:09 ` Sergei Shtylyov
2016-01-19 17:22 ` Tejun Heo
2016-01-19 17:23 ` Sergei Shtylyov
2016-01-25 20:46 ` [PATCH v3] " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114223732.GG3520@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).