linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: tchalamarla@caviumnetworks.com
Cc: stripathi@apm.com, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536
Date: Sun, 14 Feb 2016 12:01:52 -0500	[thread overview]
Message-ID: <20160214170152.GC3965@htj.duckdns.org> (raw)
In-Reply-To: <1455319230-30201-1-git-send-email-tchalamarla@caviumnetworks.com>

Hello,

On Fri, Feb 12, 2016 at 03:20:30PM -0800, tchalamarla@caviumnetworks.com wrote:
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 546a369..76e310e 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1560,6 +1560,9 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	if (ahci_broken_devslp(pdev))
>  		hpriv->flags |= AHCI_HFLAG_NO_DEVSLP;
>  
> +	if (pdev->vendor == 0x177d && pdev->device == 0xa01c)
> +		ahci_thunderx_init(&pdev->dev, hpriv);

So, this would make ahci fail to build if thunderx is not configured.
Maybe we should add an additional callback to update hpriv.

>  	/* save initial config */
>  	ahci_pci_save_initial_config(pdev, hpriv);
>  
> diff --git a/drivers/ata/ahci_thunderx.c b/drivers/ata/ahci_thunderx.c

This driver isn't upstream yet, right?  Maybe just fold this change
together?

Thanks.

-- 
tejun

  parent reply	other threads:[~2016-02-14 17:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12 23:20 [PATCH V2] AHCI: Workaround for ThunderX Errata#22536 tchalamarla
2016-02-13 16:54 ` Sergei Shtylyov
2016-02-14 17:01 ` Tejun Heo [this message]
2016-02-15  3:36   ` Tirumalesh Chalamarla
2016-02-15 18:30     ` Tejun Heo
2016-02-16 14:42       ` Robert Richter
2016-02-16 19:14         ` Tirumalesh Chalamarla
2016-02-16 19:38           ` David Daney
2016-02-16 19:50             ` Tirumalesh Chalamarla
2016-02-16 21:14               ` Robert Richter
2016-02-16 23:13                 ` Tirumalesh Chalamarla
2016-02-17 11:29                   ` Will Deacon
2016-02-17 18:57                     ` David Daney
2016-02-17 20:00                       ` Tejun Heo
2016-02-17 21:46                         ` Tirumalesh Chalamarla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160214170152.GC3965@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stripathi@apm.com \
    --cc=tchalamarla@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).