From: Tejun Heo <tj@kernel.org>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH libata/for-4.6] libata: fix unbalanced spin_lock_irqsave/spin_unlock_irq() in ata_scsi_park_show()
Date: Fri, 19 Feb 2016 11:01:48 -0500 [thread overview]
Message-ID: <20160219160148.GJ13177@mtj.duckdns.org> (raw)
In-Reply-To: <87ziuxgpnu.fsf@denkblock.local>
On Fri, Feb 19, 2016 at 07:49:57AM +0100, Elias Oltmanns wrote:
> On 18 February 2016 at 17:54 CET, Tejun Heo wrote:
> >> From 3948b6f2b7677165324afe52c3bd0088ca7c776c Mon Sep 17 00:00:00 2001
> > From: Tejun Heo <tj@kernel.org>
> > Date: Thu, 18 Feb 2016 11:50:37 -0500
> >
> > ata_scsi_park_show() was pairing spin_lock_irqsave() with
> > spin_unlock_irq(). As the function is always called with irq enabled,
> > it didn't actually break anything. Use spin_lock_irq() instead.
>
> Thanks for taking care of this. As I stated earlier, I'd suggest exactly
> the same change for ata_scsc_park_store() too, though.
Send a patch?
--
tejun
prev parent reply other threads:[~2016-02-19 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 19:24 libata: Implement disk shock protection support Dan Carpenter
2016-02-18 9:45 ` Elias Oltmanns
2016-02-18 16:54 ` [PATCH libata/for-4.6] libata: fix unbalanced spin_lock_irqsave/spin_unlock_irq() in ata_scsi_park_show() Tejun Heo
2016-02-19 6:49 ` Elias Oltmanns
2016-02-19 16:01 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219160148.GJ13177@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=eo@nebensachen.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).