From: Tejun Heo <tj@kernel.org>
To: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
"# 2 . 6 . 18" <stable@vger.kernel.org>
Subject: Re: [PATCH] libata: Align ata_device's id on a cacheline
Date: Thu, 25 Feb 2016 16:37:51 -0500 [thread overview]
Message-ID: <20160225213751.GH6092@mtj.duckdns.org> (raw)
In-Reply-To: <1456327003-16295-1-git-send-email-harvey.hunt@imgtec.com>
On Wed, Feb 24, 2016 at 03:16:43PM +0000, Harvey Hunt wrote:
> The id buffer in ata_device is a DMA target, but it isn't explicitly
> cacheline aligned. Due to this, adjacent fields can be overwritten with
> stale data from memory on non coherent architectures. As a result, the
> kernel is sometimes unable to communicate with an ATA device.
>
> Fix this by ensuring that the id buffer is cacheline aligned.
>
> This issue is similar to that fixed by Commit 84bda12af31f
> ("libata: align ap->sector_buf").
>
> Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: <stable@vger.kernel.org> # 2.6.18
Applied to libata/for-4.5-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2016-02-25 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 15:16 [PATCH] libata: Align ata_device's id on a cacheline Harvey Hunt
2016-02-25 21:37 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225213751.GH6092@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=harvey.hunt@imgtec.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).