From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mark Lord <mlord@pobox.com>
Cc: linux-ide@vger.kernel.org
Subject: [report] sata_qstor.c: ancient pointer math bug
Date: Wed, 2 Mar 2016 12:44:58 +0300 [thread overview]
Message-ID: <20160302094458.GA5213@mwanda> (raw)
Hello Mark Lord matches,
The patch 1da177e4c3f4 from Apr 16, 2005, leads to the following static
checker warning:
drivers/ata/sata_qstor.c:270 qs_fill_sg()
warn: was expecting 4 bytes for 'prd'
drivers/ata/sata_qstor.c
252 static unsigned int qs_fill_sg(struct ata_queued_cmd *qc)
253 {
254 struct scatterlist *sg;
255 struct ata_port *ap = qc->ap;
256 struct qs_port_priv *pp = ap->private_data;
257 u8 *prd = pp->pkt + QS_CPB_BYTES;
258 unsigned int si;
259
260 for_each_sg(qc->sg, sg, qc->n_elem, si) {
261 u64 addr;
262 u32 len;
263
264 addr = sg_dma_address(sg);
265 *(__le64 *)prd = cpu_to_le64(addr);
266 prd += sizeof(u64);
267
268 len = sg_dma_len(sg);
269 *(__le32 *)prd = cpu_to_le32(len);
270 prd += sizeof(u64);
This is almost certainly a cut and paste bug where prd += sizeof(u32)
was intended. Probably no one cares at this point though...
271
272 VPRINTK("PRD[%u] = (0x%llX, 0x%X)\n", si,
273 (unsigned long long)addr, len);
274 }
275
276 return si;
277 }
regards,
dan carpenter
next reply other threads:[~2016-03-02 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 9:44 Dan Carpenter [this message]
2016-03-02 14:28 ` [report] sata_qstor.c: ancient pointer math bug Mark Lord
2016-03-02 14:30 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302094458.GA5213@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).