linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Carolin Latze <carolin.latze@gmail.com>
Cc: Hans De Goede <hdegoede@redhat.com>,
	linux-ide <linux-ide@vger.kernel.org>
Subject: Re: kernel crash with lite-on sata controller Dell XPS 13 9343
Date: Wed, 2 Mar 2016 10:25:59 -0500	[thread overview]
Message-ID: <20160302152559.GA4282@mtj.duckdns.org> (raw)
In-Reply-To: <56D6A86C.9070007@gmail.com>

Hello, Carolin.

On Wed, Mar 02, 2016 at 09:46:36AM +0100, Carolin Latze wrote:
> please see attached screen capture. If there is any better way to capture
> those logs than taking pictures, please let me know

Heh, so there have been quite a few cases where device locks up after
a lot of NCQ commands are issued and/or data transfer is taking place
at high rate but device locking up on plain WRITE_DMA_EXT is pretty
new.  Hmmm.... Does the following patch make any difference?

diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
index 45586c1..95c4d5c 100644
--- a/drivers/ata/ahci.h
+++ b/drivers/ata/ahci.h
@@ -366,8 +366,8 @@ extern struct device_attribute *ahci_sdev_attrs[];
 #define AHCI_SHT(drv_name)						\
 	ATA_NCQ_SHT(drv_name),						\
 	.can_queue		= AHCI_MAX_CMDS - 1,			\
-	.sg_tablesize		= AHCI_MAX_SG,				\
-	.dma_boundary		= AHCI_DMA_BOUNDARY,			\
+	.sg_tablesize		= LIBATA_MAX_PRD,			\
+	.dma_boundary		= ATA_DMA_BOUNDARY			\
 	.shost_attrs		= ahci_shost_attrs,			\
 	.sdev_attrs		= ahci_sdev_attrs
 

  parent reply	other threads:[~2016-03-02 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 21:45 kernel crash with lite-on sata controller Dell XPS 13 9343 Carolin Latze
2016-02-25 21:51 ` Tejun Heo
2016-02-25 21:53   ` Carolin Latze
2016-02-25 22:01     ` Tejun Heo
     [not found]       ` <56D6A86C.9070007@gmail.com>
2016-03-02 15:25         ` Tejun Heo [this message]
2016-03-14 16:02           ` Carolin Latze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302152559.GA4282@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=carolin.latze@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).