From: Christoph Hellwig <hch@infradead.org>
To: Shaun Tancheff <shaun.tancheff@seagate.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Shaun Tancheff <shaun@tancheff.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v2] Add support for SCT Write Same
Date: Mon, 13 Jun 2016 01:02:43 -0700 [thread overview]
Message-ID: <20160613080243.GB26544@infradead.org> (raw)
In-Reply-To: <CAJVOszAO7YxznaUNs1+HaN=aRaA3yPiQDYHSQw+To6BKMEL++A@mail.gmail.com>
On Thu, Jun 09, 2016 at 10:24:40PM -0500, Shaun Tancheff wrote:
> > - The plain page_address above looks harmful, how do we know that
> > the page is mapped into kernel memory? This might actually be broken
> > already, though.
>
> I think it just happens to work because it's always used with a recently
> allocated page. Fixing it to include the (possible) offset is just a good thing.
I haven't spent much time with libata recently, but what prevents an
arbitrary user page ending up here through SG_IO?
prev parent reply other threads:[~2016-06-13 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 6:32 [PATCH v2] Add support for Write Same via SCT Shaun Tancheff
2016-06-09 6:32 ` [PATCH v2] Add support for SCT Write Same Shaun Tancheff
2016-06-09 9:22 ` Christoph Hellwig
2016-06-10 3:24 ` Shaun Tancheff
2016-06-13 8:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613080243.GB26544@infradead.org \
--to=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shaun.tancheff@seagate.com \
--cc=shaun@tancheff.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).