From: Tejun Heo <tj@kernel.org>
To: Tom Yan <tom.ty89@gmail.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
martin.petersen@oracle.com, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 1/2] libata-scsi: improve TRIM translation
Date: Tue, 5 Jul 2016 18:43:20 -0400 [thread overview]
Message-ID: <20160705224320.GE25394@htj.duckdns.org> (raw)
In-Reply-To: <CAGnHSEkoJPzi0qQbu2SjqYehFW9o1g8d-mm=jYuQk=YgBKa8Yw@mail.gmail.com>
On Wed, Jul 06, 2016 at 03:10:51AM +0800, Tom Yan wrote:
> Well it is exactly what the patch does. We no longer do the "divide it
> by 8" thing each time we want to know the now defined TRIM_RANGE_NUM.
>
> ata_set_lba_range_entries() has only been used by
> ata_scsi_write_same_xlat()
> (http://lxr.free-electrons.com/ident?i=ata_set_lba_range_entries,
> although the comment of it seems to tell otherwise). That's why I
> (could) changed the function itself and the param ("512")
> ata_scsi_write_same_xlat() passes to it.
Heh, I find the patch difficult to follow too and it shouldn't be.
Can you please split them up and explain what's going on in the
description?
Thanks.
--
tejun
prev parent reply other threads:[~2016-07-05 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 6:45 [PATCH v2 1/2] libata-scsi: improve TRIM translation tom.ty89
2016-07-05 11:04 ` Sergei Shtylyov
2016-07-05 19:10 ` Tom Yan
2016-07-05 22:43 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705224320.GE25394@htj.duckdns.org \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox