* [PATCH resend 1/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT
@ 2016-07-06 17:13 tom.ty89
2016-07-06 17:32 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: tom.ty89 @ 2016-07-06 17:13 UTC (permalink / raw)
To: tj, martin.petersen, sergei.shtylyov; +Cc: linux-ide, linux-scsi, Tom Yan
From: Tom Yan <tom.ty89@gmail.com>
It does not make sense and is confusing to respond with "Invalid
field in CDB" while we have no support at all implemented for
FORMAT UNIT. It is decent to let it go to the default, which
will respond with "Invalid command operation code" instead.
Signed-off-by: Tom Yan <tom.ty89@gmail.com>
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index bfec66f..f1125fd 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -4039,11 +4039,6 @@ void ata_scsi_simulate(struct ata_device *dev, struct scsi_cmnd *cmd)
args.done = cmd->scsi_done;
switch(scsicmd[0]) {
- /* TODO: worth improving? */
- case FORMAT_UNIT:
- ata_scsi_invalid_field(dev, cmd, 0);
- break;
-
case INQUIRY:
if (scsicmd[1] & 2) /* is CmdDt set? */
ata_scsi_invalid_field(dev, cmd, 1);
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH resend 1/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT
2016-07-06 17:13 [PATCH resend 1/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT tom.ty89
@ 2016-07-06 17:32 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2016-07-06 17:32 UTC (permalink / raw)
To: tom.ty89; +Cc: martin.petersen, sergei.shtylyov, linux-ide, linux-scsi
On Thu, Jul 07, 2016 at 01:13:08AM +0800, tom.ty89@gmail.com wrote:
> From: Tom Yan <tom.ty89@gmail.com>
>
> It does not make sense and is confusing to respond with "Invalid
> field in CDB" while we have no support at all implemented for
> FORMAT UNIT. It is decent to let it go to the default, which
> will respond with "Invalid command operation code" instead.
>
> Signed-off-by: Tom Yan <tom.ty89@gmail.com>
Applied to libata/for-4.8.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-06 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-06 17:13 [PATCH resend 1/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT tom.ty89
2016-07-06 17:32 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).