From: Tejun Heo <tj@kernel.org>
To: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] silence warning in drivers/ata/libata-scsi.c when building W=1
Date: Mon, 1 Aug 2016 11:04:29 -0400 [thread overview]
Message-ID: <20160801150429.GD2542@mtj.duckdns.org> (raw)
In-Reply-To: <8997.1470022114@turing-police.cc.vt.edu>
On Sun, Jul 31, 2016 at 11:28:34PM -0400, Valdis Kletnieks wrote:
> When building with W=1, we get these warnings:
>
> drivers/ata/libata-scsi.c: In function 'ata_mselect_caching':
> drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
> if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
> ~~~~~^~~~~~~~~
> drivers/ata/libata-scsi.c: In function 'ata_mselect_control':
> drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
> if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
> ~~~~~^~~~~~~~~
>
> So give them the extra () and make things a bit clearer for both the
> compiler and programmer...
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
The offending commit got already reverted.
Thanks!
--
tejun
prev parent reply other threads:[~2016-08-01 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 3:28 [PATCH] silence warning in drivers/ata/libata-scsi.c when building W=1 Valdis Kletnieks
2016-08-01 15:04 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801150429.GD2542@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).