From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baole Ni Subject: [PATCH 0245/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:52:52 +0800 Message-ID: <20160802105252.30074-1-baolex.ni@intel.com> Return-path: Received: from mga09.intel.com ([134.134.136.24]:15779 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755567AbcHBLdK (ORCPT ); Tue, 2 Aug 2016 07:33:10 -0400 Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: davem@davemloft.net, wsa@the-dreams.de, linux@roeck-us.net, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, aduggan@synaptics.com, dianders@chromium.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/ide/cs5536.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/cs5536.c b/drivers/ide/cs5536.c index de9185d..5a9f702 100644 --- a/drivers/ide/cs5536.c +++ b/drivers/ide/cs5536.c @@ -302,5 +302,5 @@ MODULE_DESCRIPTION("low-level driver for the CS5536 IDE controller"); MODULE_LICENSE("GPL"); MODULE_DEVICE_TABLE(pci, cs5536_pci_tbl); -module_param_named(msr, use_msr, int, 0644); +module_param_named(msr, use_msr, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(msr, "Force using MSR to configure IDE function (Default: 0)"); -- 2.9.2