From: Christoph Hellwig <hch@lst.de>
To: Shaun Tancheff <shaun@tancheff.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>, Tejun Heo <tj@kernel.org>,
Josh Bingaman <josh.bingaman@seagate.com>,
Shaun Tancheff <shaun.tancheff@seagate.com>
Subject: Re: [PATCH v5 1/2] Use kmap_atomic when rewriting attached page
Date: Thu, 11 Aug 2016 16:13:34 +0200 [thread overview]
Message-ID: <20160811141334.GA16956@lst.de> (raw)
In-Reply-To: <1470790829-3793-2-git-send-email-shaun@tancheff.com>
> +static unsigned int ata_format_dsm_trim_descr(struct scatterlist *sg, u32 num,
> + u64 sector, u32 count)
> +{
> + void *ptr = kmap_atomic(sg_page(sg));
Please use sg_copy_from_buffer to be safe against all corner cases.
next prev parent reply other threads:[~2016-08-11 14:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 1:00 [PATCH v5 0/2] Add support for SCT Write Same Shaun Tancheff
2016-08-10 1:00 ` [PATCH v5 1/2] Use kmap_atomic when rewriting attached page Shaun Tancheff
2016-08-10 10:56 ` Tom Yan
2016-08-10 12:26 ` Shaun Tancheff
2016-08-11 14:13 ` Christoph Hellwig [this message]
2016-08-10 1:00 ` [PATCH v5 2/2] Add support for SCT Write Same Shaun Tancheff
2016-08-10 6:31 ` Tom Yan
2016-08-10 11:30 ` Tom Yan
2016-08-10 14:34 ` Shaun Tancheff
2016-08-10 16:50 ` Tom Yan
2016-08-10 18:29 ` Shaun Tancheff
2016-08-11 8:04 ` Tom Yan
2016-08-11 1:47 ` Martin K. Petersen
2016-08-11 8:46 ` Tom Yan
2016-08-12 1:18 ` Martin K. Petersen
2016-08-11 1:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811141334.GA16956@lst.de \
--to=hch@lst.de \
--cc=josh.bingaman@seagate.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaun.tancheff@seagate.com \
--cc=shaun@tancheff.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox