* [PATCH]pata_ninja32: Avoid corrupting status flags
@ 2016-08-30 15:47 One Thousand Gnomes
2016-08-30 20:14 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: One Thousand Gnomes @ 2016-08-30 15:47 UTC (permalink / raw)
To: linux-ide, tj
From: Alan Cox <alan@linux.intel.com>
Ninja32 needs to set some flags to indicate it does 32bit IO. However it currently assigns this which
loses the initializing flag and causes a warning spew. Fix it to use a logical or as is intended.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Tested-by: Ellmar Stelnberger <estellnb@elstel.org>
diff --git a/drivers/ata/pata_ninja32.c b/drivers/ata/pata_ninja32.c
index 633aa29..44f97ad 100644
--- a/drivers/ata/pata_ninja32.c
+++ b/drivers/ata/pata_ninja32.c
@@ -144,7 +144,7 @@ static int ninja32_init_one(struct pci_dev *dev, const struct pci_device_id *id)
ap->ioaddr.altstatus_addr = base + 0x1E;
ap->ioaddr.bmdma_addr = base;
ata_sff_std_ports(&ap->ioaddr);
- ap->pflags = ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE;
+ ap->pflags |= ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE;
ninja32_program(base);
/* FIXME: Should we disable them at remove ? */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH]pata_ninja32: Avoid corrupting status flags
2016-08-30 15:47 [PATCH]pata_ninja32: Avoid corrupting status flags One Thousand Gnomes
@ 2016-08-30 20:14 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2016-08-30 20:14 UTC (permalink / raw)
To: One Thousand Gnomes; +Cc: linux-ide
On Tue, Aug 30, 2016 at 04:47:02PM +0100, One Thousand Gnomes wrote:
> From: Alan Cox <alan@linux.intel.com>
>
> Ninja32 needs to set some flags to indicate it does 32bit IO. However it currently assigns this which
> loses the initializing flag and causes a warning spew. Fix it to use a logical or as is intended.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> Tested-by: Ellmar Stelnberger <estellnb@elstel.org>
Applied to libata/for-4.8-fixes and pushed out.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-30 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-30 15:47 [PATCH]pata_ninja32: Avoid corrupting status flags One Thousand Gnomes
2016-08-30 20:14 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).