* [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"
@ 2016-09-28 1:46 yuantian.tang
2016-09-29 8:55 ` Tejun Heo
0 siblings, 1 reply; 6+ messages in thread
From: yuantian.tang @ 2016-09-28 1:46 UTC (permalink / raw)
To: tj, linux-ide; +Cc: Tang Yuantian, Tang Yuantian
From: Tang Yuantian <Yuantian.Tang@nxp.com>
This reverts commit 640847298e2b7f19 ("ahci: qoriq: Disable NCQ
on ls2080a SoC")
The erratum has been fixed in ls2080a v2.0 and later soc.
Since ls2080a v1.0 has rarely been released, it can be safely
reverted.
Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
---
drivers/ata/ahci_qoriq.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c
index 7bdee9b..2342fca 100644
--- a/drivers/ata/ahci_qoriq.c
+++ b/drivers/ata/ahci_qoriq.c
@@ -137,7 +137,7 @@ static struct ata_port_operations ahci_qoriq_ops = {
.hardreset = ahci_qoriq_hardreset,
};
-static struct ata_port_info ahci_qoriq_port_info = {
+static const struct ata_port_info ahci_qoriq_port_info = {
.flags = AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
.pio_mask = ATA_PIO4,
.udma_mask = ATA_UDMA6,
@@ -221,12 +221,6 @@ static int ahci_qoriq_probe(struct platform_device *pdev)
if (rc)
goto disable_resources;
- /* Workaround for ls2080a */
- if (qoriq_priv->type == AHCI_LS2080A) {
- hpriv->flags |= AHCI_HFLAG_NO_NCQ;
- ahci_qoriq_port_info.flags &= ~ATA_FLAG_NCQ;
- }
-
rc = ahci_platform_init_host(pdev, hpriv, &ahci_qoriq_port_info,
&ahci_qoriq_sht);
if (rc)
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"
2016-09-28 1:46 [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC" yuantian.tang
@ 2016-09-29 8:55 ` Tejun Heo
2016-09-29 9:07 ` Y.T. Tang
0 siblings, 1 reply; 6+ messages in thread
From: Tejun Heo @ 2016-09-29 8:55 UTC (permalink / raw)
To: yuantian.tang; +Cc: linux-ide
Hello,
On Wed, Sep 28, 2016 at 09:46:12AM +0800, yuantian.tang@nxp.com wrote:
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
>
> This reverts commit 640847298e2b7f19 ("ahci: qoriq: Disable NCQ
> on ls2080a SoC")
>
> The erratum has been fixed in ls2080a v2.0 and later soc.
> Since ls2080a v1.0 has rarely been released, it can be safely
> reverted.
Hmm... going by the description, I'm not sure whether this is a good
idea. What's "rarely been released"? Are there chips out in the
wild? Can't we blacklist v2.0+ only?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"
2016-09-29 8:55 ` Tejun Heo
@ 2016-09-29 9:07 ` Y.T. Tang
2016-09-29 9:58 ` Tejun Heo
0 siblings, 1 reply; 6+ messages in thread
From: Y.T. Tang @ 2016-09-29 9:07 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide@vger.kernel.org
> -----Original Message-----
> From: Tejun Heo [mailto:htejun@gmail.com] On Behalf Of Tejun Heo
> Sent: Thursday, September 29, 2016 4:55 PM
> To: Y.T. Tang <yuantian.tang@nxp.com>
> Cc: linux-ide@vger.kernel.org
> Subject: Re: [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a
> SoC"
>
> Hello,
>
> On Wed, Sep 28, 2016 at 09:46:12AM +0800, yuantian.tang@nxp.com wrote:
> > From: Tang Yuantian <Yuantian.Tang@nxp.com>
> >
> > This reverts commit 640847298e2b7f19 ("ahci: qoriq: Disable NCQ on
> > ls2080a SoC")
> >
> > The erratum has been fixed in ls2080a v2.0 and later soc.
> > Since ls2080a v1.0 has rarely been released, it can be safely
> > reverted.
>
> Hmm... going by the description, I'm not sure whether this is a good idea.
> What's "rarely been released"? Are there chips out in the wild? Can't we
> blacklist v2.0+ only?
>
In reality, customer will not get any ls2080a v1.0 soc. Neither apply to any products. If blacklisting v2.0, we need to check the soc version which is not suitable in the driver.
Anyway, reverting this commit won't create any side effect.
Regards,
Yuantian
> Thanks.
>
> --
> tejun
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"
2016-09-29 9:07 ` Y.T. Tang
@ 2016-09-29 9:58 ` Tejun Heo
0 siblings, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2016-09-29 9:58 UTC (permalink / raw)
To: Y.T. Tang; +Cc: linux-ide@vger.kernel.org
Hello,
On Thu, Sep 29, 2016 at 09:07:18AM +0000, Y.T. Tang wrote:
> In reality, customer will not get any ls2080a v1.0 soc. Neither
> apply to any products. If blacklisting v2.0, we need to check the
> soc version which is not suitable in the driver. Anyway, reverting
> this commit won't create any side effect.
Can you please include this in the commit description?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"
@ 2016-09-30 6:12 yuantian.tang
2016-09-30 6:29 ` Y.T. Tang
0 siblings, 1 reply; 6+ messages in thread
From: yuantian.tang @ 2016-09-30 6:12 UTC (permalink / raw)
To: tj, linux-ide; +Cc: Tang Yuantian, Tang Yuantian
From: Tang Yuantian <Yuantian.Tang@nxp.com>
This reverts commit 640847298e2b7f19 ("ahci: qoriq: Disable NCQ
on ls2080a SoC")
The erratum has been fixed in ls2080a v2.0 and later soc.
In reality, customer will not get any ls2080a v1.0 soc. Neither apply
to any products. So reverting this commit won't create any side effect.
Blacklisting v2.0 could also be a option, but that needs to check the
soc version which is not suitable in the driver.
Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
---
drivers/ata/ahci_qoriq.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c
index 925c4b6..1eba8df 100644
--- a/drivers/ata/ahci_qoriq.c
+++ b/drivers/ata/ahci_qoriq.c
@@ -136,7 +136,7 @@ static struct ata_port_operations ahci_qoriq_ops = {
.hardreset = ahci_qoriq_hardreset,
};
-static struct ata_port_info ahci_qoriq_port_info = {
+static const struct ata_port_info ahci_qoriq_port_info = {
.flags = AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
.pio_mask = ATA_PIO4,
.udma_mask = ATA_UDMA6,
@@ -221,12 +221,6 @@ static int ahci_qoriq_probe(struct platform_device *pdev)
if (rc)
goto disable_resources;
- /* Workaround for ls2080a */
- if (qoriq_priv->type == AHCI_LS2080A) {
- hpriv->flags |= AHCI_HFLAG_NO_NCQ;
- ahci_qoriq_port_info.flags &= ~ATA_FLAG_NCQ;
- }
-
rc = ahci_platform_init_host(pdev, hpriv, &ahci_qoriq_port_info,
&ahci_qoriq_sht);
if (rc)
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"
2016-09-30 6:12 yuantian.tang
@ 2016-09-30 6:29 ` Y.T. Tang
0 siblings, 0 replies; 6+ messages in thread
From: Y.T. Tang @ 2016-09-30 6:29 UTC (permalink / raw)
To: Y.T. Tang, tj@kernel.org, linux-ide@vger.kernel.org
Please ignore this, it is a duplicated patch.
Regards,
Yuantian
> -----Original Message-----
> From: yuantian.tang@nxp.com [mailto:yuantian.tang@nxp.com]
> Sent: Friday, September 30, 2016 2:13 PM
> To: tj@kernel.org; linux-ide@vger.kernel.org
> Cc: Y.T. Tang <yuantian.tang@nxp.com>; Y.T. Tang <yuantian.tang@nxp.com>
> Subject: [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"
>
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
>
> This reverts commit 640847298e2b7f19 ("ahci: qoriq: Disable NCQ on ls2080a
> SoC")
>
> The erratum has been fixed in ls2080a v2.0 and later soc.
> In reality, customer will not get any ls2080a v1.0 soc. Neither apply to any
> products. So reverting this commit won't create any side effect.
>
> Blacklisting v2.0 could also be a option, but that needs to check the soc
> version which is not suitable in the driver.
>
> Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
> ---
> drivers/ata/ahci_qoriq.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c index
> 925c4b6..1eba8df 100644
> --- a/drivers/ata/ahci_qoriq.c
> +++ b/drivers/ata/ahci_qoriq.c
> @@ -136,7 +136,7 @@ static struct ata_port_operations ahci_qoriq_ops = {
> .hardreset = ahci_qoriq_hardreset,
> };
>
> -static struct ata_port_info ahci_qoriq_port_info = {
> +static const struct ata_port_info ahci_qoriq_port_info = {
> .flags = AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> .pio_mask = ATA_PIO4,
> .udma_mask = ATA_UDMA6,
> @@ -221,12 +221,6 @@ static int ahci_qoriq_probe(struct platform_device
> *pdev)
> if (rc)
> goto disable_resources;
>
> - /* Workaround for ls2080a */
> - if (qoriq_priv->type == AHCI_LS2080A) {
> - hpriv->flags |= AHCI_HFLAG_NO_NCQ;
> - ahci_qoriq_port_info.flags &= ~ATA_FLAG_NCQ;
> - }
> -
> rc = ahci_platform_init_host(pdev, hpriv, &ahci_qoriq_port_info,
> &ahci_qoriq_sht);
> if (rc)
> --
> 2.1.0.27.g96db324
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-30 19:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-28 1:46 [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC" yuantian.tang
2016-09-29 8:55 ` Tejun Heo
2016-09-29 9:07 ` Y.T. Tang
2016-09-29 9:58 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2016-09-30 6:12 yuantian.tang
2016-09-30 6:29 ` Y.T. Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).