From: Adam Manzanares <adam.manzanares@hgst.com>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/3] ata: Enabling ATA Command Priorities
Date: Fri, 30 Sep 2016 09:04:13 -0700 [thread overview]
Message-ID: <20160930160413.GB13637@hgst.com> (raw)
In-Reply-To: <20160929084529.GC11087@mtj.duckdns.org>
The 09/29/2016 10:45, Tejun Heo wrote:
> Hello,
>
> On Tue, Sep 27, 2016 at 11:14:55AM -0700, Adam Manzanares wrote:
> > +/**
> > + * ata_ncq_prio_enabled - Test whether NCQ prio is enabled
> > + * @dev: ATA device to test for
> > + *
> > + * LOCKING:
> > + * spin_lock_irqsave(host lock)
> > + *
> > + * RETURNS:
> > + * 1 if NCQ prio is enabled for @dev, 0 otherwise.
> > + */
> > +static inline int ata_ncq_prio_enabled(struct ata_device *dev)
> > +{
> > + return (dev->flags & (ATA_DFLAG_PIO | ATA_DFLAG_NCQ_OFF |
> > + ATA_DFLAG_NCQ_PRIO)) == ATA_DFLAG_NCQ_PRIO;
>
> I'm not sure this needs to test PIO and NCQ_OFF. This functions
> pretty much can assume that it'd be only called in NCQ context, no?
>
This should only be called in the NCQ context so these checks are redundant
I'll clean this up in the next version of the patches.
> Thanks.
>
> --
> tejun
Take care,
Adam
next prev parent reply other threads:[~2016-09-30 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 18:14 [PATCH 0/3] Enabling ATA Command Priorities Adam Manzanares
2016-09-27 18:14 ` [PATCH 1/3] block: Add iocontext priority to request Adam Manzanares
2016-09-29 8:40 ` Tejun Heo
2016-09-30 16:02 ` Adam Manzanares
2016-10-02 8:53 ` Tejun Heo
2016-10-04 15:49 ` Adam Manzanares
2016-10-04 20:52 ` Tejun Heo
2016-09-27 18:14 ` [PATCH 2/3] ata: Enabling ATA Command Priorities Adam Manzanares
2016-09-29 8:45 ` Tejun Heo
2016-09-30 16:04 ` Adam Manzanares [this message]
2016-09-27 18:14 ` [PATCH 3/3] ata: ATA Command Priority Disabled By Default Adam Manzanares
2016-09-28 2:06 ` [PATCH 0/3] Enabling ATA Command Priorities Christoph Hellwig
2016-09-28 3:43 ` Adam Manzanares
2016-09-29 8:48 ` tj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930160413.GB13637@hgst.com \
--to=adam.manzanares@hgst.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).