From: Tejun Heo <tj@kernel.org>
To: Adam Manzanares <adam.manzanares@hgst.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/3] block: Add iocontext priority to request
Date: Tue, 4 Oct 2016 16:52:27 -0400 [thread overview]
Message-ID: <20161004205227.GL4205@htj.duckdns.org> (raw)
In-Reply-To: <20161004154917.GA4764@hgst.com>
Hello, Adam.
On Tue, Oct 04, 2016 at 08:49:18AM -0700, Adam Manzanares wrote:
> > I wonder whether the right thing to do is adding bio->bi_ioprio which
> > is initialized on bio submission and carried through req->ioprio.
>
> I looked around and thought about this and I'm not sure if this will help.
> I dug into the bio submission code and I thought generic_make_request was
> the best place to save the ioprio information. This is quite close in
> the call stack to init_request_from bio. Bcache sets the bio priority before
> the submission, so we would have to check to see if the bio priority was
> valid on bio submission leaving us with the same problem. Leaving the
> priority in the upper bits of bio->bi_rw is fine with me. It may help to
> have the bio->bi_ioprio for clarity, but I think we will still face the
> issue of having to check if this value is set when we submit the bio or
> init the request so I'm leaning towards leaving it as is.
I see. Thanks for looking into it. It's icky that we don't have a
clear path of propagating ioprio but let's save that for another day.
--
tejun
next prev parent reply other threads:[~2016-10-04 20:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 18:14 [PATCH 0/3] Enabling ATA Command Priorities Adam Manzanares
2016-09-27 18:14 ` [PATCH 1/3] block: Add iocontext priority to request Adam Manzanares
2016-09-29 8:40 ` Tejun Heo
2016-09-30 16:02 ` Adam Manzanares
2016-10-02 8:53 ` Tejun Heo
2016-10-04 15:49 ` Adam Manzanares
2016-10-04 20:52 ` Tejun Heo [this message]
2016-09-27 18:14 ` [PATCH 2/3] ata: Enabling ATA Command Priorities Adam Manzanares
2016-09-29 8:45 ` Tejun Heo
2016-09-30 16:04 ` Adam Manzanares
2016-09-27 18:14 ` [PATCH 3/3] ata: ATA Command Priority Disabled By Default Adam Manzanares
2016-09-28 2:06 ` [PATCH 0/3] Enabling ATA Command Priorities Christoph Hellwig
2016-09-28 3:43 ` Adam Manzanares
2016-09-29 8:48 ` tj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004205227.GL4205@htj.duckdns.org \
--to=tj@kernel.org \
--cc=adam.manzanares@hgst.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).