From: Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
To: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: [PATCH] Fix interface autodetection in legacy IDE driver (trial #2)
Date: Tue, 11 Oct 2016 22:12:45 -0300 [thread overview]
Message-ID: <20161012011245.GA22684@giustizia> (raw)
Hello,
This humble patch was sent one or two months before, and had no actions,
except for a colleague reply which friendly pointed out some formatting
problems (which were solved in a second message).
It relates to an old code, the legacy IDE driver, but the bug it
addresses is real. The code, although rarely used, is
still there to be compiled if one chooses to do so (like me).
Also, the fix has a very low risk of present collateral effects IMHO.
It is already compiled and tested in some embedded machines.
So, again IMHO, it is worth be fixed.
This email is a second trial with it. I hope it can help the one or two
guys out there which are still running the legacy IDE driver and
haven't noticed the former email.
Best regards,
Signed-off-by: Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
---
drivers/ide/ide-generic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/ide-generic.c b/drivers/ide/ide-generic.c
index 54d7c4685d23aa5e62ce606e7b994a57bb54b08a..419818a39c270d3ad219e8f7b5df56a9aea3d640 100644
--- a/drivers/ide/ide-generic.c
+++ b/drivers/ide/ide-generic.c
@@ -96,10 +96,10 @@ static int __init ide_generic_init(void)
printk(KERN_INFO DRV_NAME ": please use \"probe_mask=0x3f\" "
"module parameter for probing all legacy ISA IDE ports\n");
- if (primary == 0)
+ if (primary)
probe_mask |= 0x1;
- if (secondary == 0)
+ if (secondary)
probe_mask |= 0x2;
} else
printk(KERN_INFO DRV_NAME ": enforcing probing of I/O ports "
--
2.8.2
next reply other threads:[~2016-10-12 1:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 1:12 Luiz Carlos Ramos [this message]
2016-12-26 16:47 ` [PATCH] Fix interface autodetection in legacy IDE driver (trial #2) David Miller
2016-12-27 10:08 ` Bartlomiej Zolnierkiewicz
2016-12-27 16:06 ` Bartlomiej Zolnierkiewicz
2016-12-27 16:41 ` David Miller
2016-12-27 17:25 ` Bartlomiej Zolnierkiewicz
2016-12-28 0:33 ` Luiz Carlos Ramos
2016-12-28 0:38 ` David Miller
2016-12-28 11:16 ` Bartlomiej Zolnierkiewicz
2016-12-28 11:10 ` Bartlomiej Zolnierkiewicz
2016-12-30 0:52 ` Luiz Carlos Ramos
2016-12-30 16:05 ` Bartlomiej Zolnierkiewicz
2017-01-09 20:25 ` David Miller
2017-02-21 14:22 ` Luiz Carlos Ramos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012011245.GA22684@giustizia \
--to=lramos.prof@yahoo.com.br \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox