Re: [PATCH] Fix interface autodetection in legacy IDE driver (trial #2)

David Miller
2016-12-26T16:47:25Z

From: Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
Date: Tue, 11 Oct 2016 22:12:45 -0300

> This humble patch was sent one or two months before, and had no actions,
> except for a colleague reply which friendly pointed out some formatting
> problems (which were solved in a second message).
>
> It relates to an old code, the legacy IDE driver, but the bug it
> addresses is real. The code, although rarely used, is
> still there to be compiled if one chooses to do so (like me).
>
> Also, the fix has a very low risk of present collateral effects IMHO.
> It is already compiled and tested in some embedded machines.
>
> So, again IMHO, it is worth be fixed.
>
> This email is a second trial with it. I hope it can help the one or two
> guys out there which are still running the legacy IDE driver and
> haven't noticed the former email.
>
> Best regards,
>
> Signed-off-by: Luiz Carlos Ramos <lramos.prof@yahoo.com.br>

This bug was introduced by commit
20df429dd6671804999493baf2952f82582869fa ("ide-generic: handle probing
of legacy io-ports v5") which seems poorly tested.

Applied and queued up for -stable, th anks.