Re: [PATCH] Fix interface autodetection in legacy IDE driver (trial #2)

David Miller
2016-12-28T00:38:25Z

From: Luiz Carlos Ramos <lramos.prof@yahoo.com.br>
Date: Tue, 27 Dec 2016 22:33:35 -0200

> So, ide_generic_init() should test *primary for 1 in the case of an
> existing IDE primary resource, and *secondary for 1 in the case of a
> secondary IDE resource.
>
> Unpatched code checks both for zero in order to set the proper bits in
> probe_mask, and IMHO this is reversed logic.

Right, and I can't see how this is intentional at all.