From: Adam Manzanares <adam.manzanares@wdc.com>
To: Tejun Heo <tj@kernel.org>
Cc: Adam Manzanares <adam.manzanares@hgst.com>,
axboe@kernel.dk, dan.j.williams@intel.com, hare@suse.de,
martin.petersen@oracle.com, mchristi@redhat.com,
toshi.kani@hpe.com, ming.lei@canonical.com,
sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com,
suganath-prabu.subramani@broadcom.com,
linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default
Date: Thu, 13 Oct 2016 16:37:43 -0700 [thread overview]
Message-ID: <20161013233742.GA5854@hgst.com> (raw)
In-Reply-To: <20161013232230.GB32534@mtj.duckdns.org>
Hello Tejun,
The 10/13/2016 19:22, Tejun Heo wrote:
> Hello, Adam.
>
> Sorry about late reply. Was on vacation.
NP I was on vacation at the end of the week last week.
>
> On Thu, Oct 13, 2016 at 04:00:31PM -0700, Adam Manzanares wrote:
> > Add a sysfs entry to turn on priority information being passed
> > to a ATA device. By default this feature is turned off.
> >
> > This patch depends on ata: Enabling ATA Command Priorities
>
> Looks generally good but can we please use a device attribute name
> which is more specific - ie. enable_ncq_prio?
Will do, I'll also double check the naming scheme of functions and variables
also. The functions that check if the device has the ncq prio capability might
be too similar to the function that checks if the device attribute is
enabled.
>
> Thanks.
>
> --
> tejun
Take care,
Adam
prev parent reply other threads:[~2016-10-13 23:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 23:00 [PATCH v5 0/4] Enabling ATA Command Priorities Adam Manzanares
2016-10-13 23:00 ` [PATCH v5 1/4] block: Add iocontext priority to request Adam Manzanares
2016-10-13 23:00 ` [PATCH v5 2/4] fusion: remove iopriority handling Adam Manzanares
2016-10-13 23:36 ` Shaun Tancheff
2016-10-14 5:34 ` Christoph Hellwig
2016-10-14 18:08 ` Adam Manzanares
2016-10-13 23:00 ` [PATCH v5 3/4] ata: Enabling ATA Command Priorities Adam Manzanares
2016-10-13 23:23 ` Tejun Heo
2016-10-13 23:00 ` [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default Adam Manzanares
2016-10-13 23:22 ` Tejun Heo
2016-10-13 23:37 ` Adam Manzanares [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013233742.GA5854@hgst.com \
--to=adam.manzanares@wdc.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=adam.manzanares@hgst.com \
--cc=axboe@kernel.dk \
--cc=chaitra.basappa@broadcom.com \
--cc=dan.j.williams@intel.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchristi@redhat.com \
--cc=ming.lei@canonical.com \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=tj@kernel.org \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).