From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
Tejun Heo <tj@kernel.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 0/5] ahci: nvme remap support
Date: Mon, 24 Oct 2016 10:46:29 -0400 [thread overview]
Message-ID: <20161024144628.GC8633@localhost.localdomain> (raw)
In-Reply-To: <20161024124938.GB2389@lst.de>
On Mon, Oct 24, 2016 at 02:49:38PM +0200, Christoph Hellwig wrote:
> But this has a profound effect on the NVMe operation, because fo
> example the NVMe reset cycle is tied into PCIe function states.
>
> Please bring this issue up with the relevant standards comittee first,
> otherwise we're getting us into a nightmare of undefined behavior here.
>
> And it's not like Intel isn't active in this group. I'd suggest you
> talk to Amber who is the editor for both the AHCI and NVMe spec,
> that should get you started.
Amber is aware of this and was supportive in having Intel open the
specs to enable this hardware.
The nvme driver has weird hooks to support the non-standard open channel
effort, and we let Apple dictate this driver can't have q-word access.
This remapping isn't exactly the first time we're helping non-standard
devices, and Dan's series looks isolated such that it won't harm
compliant ones.
Dan,
I take it you have access to this platform. Would you be able verify if
it can successfully resume from S3 and S4?
next prev parent reply other threads:[~2016-10-24 14:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 0:25 [PATCH 0/5] ahci: nvme remap support Dan Williams
2016-10-22 0:25 ` [PATCH 1/5] " Dan Williams
2016-10-22 0:25 ` [PATCH 2/5] nvme: rename "pci" operations to "mmio" Dan Williams
2016-10-22 0:25 ` [PATCH 3/5] nvme: introduce nvme_dev_ops Dan Williams
2016-10-22 0:25 ` [PATCH 4/5] nvme: move common definitions to pci.h Dan Williams
2016-10-22 0:25 ` [PATCH 5/5] nvme: ahci remap support Dan Williams
2016-10-22 6:50 ` [PATCH 0/5] ahci: nvme " Christoph Hellwig
2016-10-22 19:26 ` Dan Williams
2016-10-23 8:34 ` Christoph Hellwig
2016-10-23 13:57 ` Dan Williams
2016-10-24 12:49 ` Christoph Hellwig
2016-10-24 14:46 ` Keith Busch [this message]
2016-10-24 15:16 ` Christoph Hellwig
2016-10-24 17:46 ` Dan Williams
2016-10-24 17:55 ` Christoph Hellwig
2016-10-24 21:01 ` Dan Williams
2016-10-24 17:57 ` Dan Williams
2016-10-24 18:21 ` Christoph Hellwig
2016-11-15 18:52 ` Christoph Hellwig
2016-11-19 6:12 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024144628.GC8633@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).