From: Tejun Heo <tj@kernel.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-ide@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 1/1] libata: Fix ATA request sense
Date: Fri, 6 Jan 2017 15:44:16 -0500 [thread overview]
Message-ID: <20170106204416.GC29909@mtj.duckdns.org> (raw)
In-Reply-To: <1482110260-14551-1-git-send-email-damien.lemoal@wdc.com>
On Mon, Dec 19, 2016 at 10:17:40AM +0900, Damien Le Moal wrote:
> For an ATA device supporting the sense data reporting feature set,
> a failed command will trigger the execution of ata_eh_request_sense if
> the result task file of the failed command has the ATA_SENSE bit set
> (sense data available bit). ata_eh_request_sense executes the
> REQUEST SENSE DATA EXT command to retrieve the sense data of the failed
> command. On success of REQUEST SENSE DATA EXT, the ATA_SENSE bit will
> NOT be set (the command succeeded) but ata_eh_request_sense
> nevertheless tests the availability of sense data by testing that bit
> presence in the result tf of the REQUEST SENSE DATA EXT command.
> This leads to a falsy assume that request sense data failed and to the
> warning message:
>
> atax.xx: request sense failed stat 50 emask 0
>
> Upon success of REQUEST SENSE DATA EXT, set the ATA_SENSE bit in the
> result task file command so that sense data can be returned by
> ata_eh_request_sense.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Applied to libata/for-4.10-fixes with patch description updated as
suggested by Sergei.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-01-06 20:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 1:17 [PATCH 1/1] libata: Fix ATA request sense Damien Le Moal
2016-12-19 7:01 ` Hannes Reinecke
2016-12-19 12:19 ` Sergei Shtylyov
2016-12-20 2:25 ` Damien Le Moal
2016-12-20 10:22 ` Sergei Shtylyov
2017-01-06 20:44 ` Tejun Heo [this message]
2017-01-10 0:54 ` Damien Le Moal
2017-01-10 15:59 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106204416.GC29909@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox