From: Tejun Heo <tj@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
linux-ide@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap.
Date: Sun, 8 Jan 2017 13:49:22 -0500 [thread overview]
Message-ID: <20170108184922.GC9403@mtj.duckdns.org> (raw)
In-Reply-To: <CAHp75Vf79R8H89npEPjbWkWqPXEKAiJ4Yru98T5nYK0x+FZuxw@mail.gmail.com>
On Sat, Jan 07, 2017 at 12:52:57AM +0200, Andy Shevchenko wrote:
> On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo <tj@kernel.org> wrote:
> > On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote:
> >> Here, If devm_ioremap will fail. It will return NULL.
> >> Then hpriv->base = NULL - 0x20000; Kernel can run into
> >> a NULL-pointer dereference. This error check will avoid
> >> NULL pointer dereference.
> >>
> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> >
> > Applied to libata/for-4.10-fixes.
>
> Hold on, why not to convert to devm_ioremap_resource() ?
Care to send the patch?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-01-08 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 17:43 [V1] ata: sata_mv:- Handle return value of devm_ioremap Arvind Yadav
2017-01-06 20:46 ` Tejun Heo
2017-01-06 22:52 ` Andy Shevchenko
2017-01-08 18:49 ` Tejun Heo [this message]
2017-01-08 22:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108184922.GC9403@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox