* [V1] ata: sata_mv:- Handle return value of devm_ioremap.
@ 2016-12-12 17:43 Arvind Yadav
2017-01-06 20:46 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Arvind Yadav @ 2016-12-12 17:43 UTC (permalink / raw)
To: tj; +Cc: linux-ide, linux-kernel
Here, If devm_ioremap will fail. It will return NULL.
Then hpriv->base = NULL - 0x20000; Kernel can run into
a NULL-pointer dereference. This error check will avoid
NULL pointer dereference.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/ata/sata_mv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index efc48bf..9d0cdad 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -4119,6 +4119,9 @@ static int mv_platform_probe(struct platform_device *pdev)
host->iomap = NULL;
hpriv->base = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
+ if (!hpriv->base)
+ return -ENOMEM;
+
hpriv->base -= SATAHC0_REG_BASE;
hpriv->clk = clk_get(&pdev->dev, NULL);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap.
2016-12-12 17:43 [V1] ata: sata_mv:- Handle return value of devm_ioremap Arvind Yadav
@ 2017-01-06 20:46 ` Tejun Heo
2017-01-06 22:52 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2017-01-06 20:46 UTC (permalink / raw)
To: Arvind Yadav; +Cc: linux-ide, linux-kernel
On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote:
> Here, If devm_ioremap will fail. It will return NULL.
> Then hpriv->base = NULL - 0x20000; Kernel can run into
> a NULL-pointer dereference. This error check will avoid
> NULL pointer dereference.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied to libata/for-4.10-fixes.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap.
2017-01-06 20:46 ` Tejun Heo
@ 2017-01-06 22:52 ` Andy Shevchenko
2017-01-08 18:49 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2017-01-06 22:52 UTC (permalink / raw)
To: Tejun Heo; +Cc: Arvind Yadav, linux-ide, linux-kernel@vger.kernel.org
On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo <tj@kernel.org> wrote:
> On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote:
>> Here, If devm_ioremap will fail. It will return NULL.
>> Then hpriv->base = NULL - 0x20000; Kernel can run into
>> a NULL-pointer dereference. This error check will avoid
>> NULL pointer dereference.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Applied to libata/for-4.10-fixes.
Hold on, why not to convert to devm_ioremap_resource() ?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap.
2017-01-06 22:52 ` Andy Shevchenko
@ 2017-01-08 18:49 ` Tejun Heo
2017-01-08 22:08 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2017-01-08 18:49 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Arvind Yadav, linux-ide, linux-kernel@vger.kernel.org
On Sat, Jan 07, 2017 at 12:52:57AM +0200, Andy Shevchenko wrote:
> On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo <tj@kernel.org> wrote:
> > On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote:
> >> Here, If devm_ioremap will fail. It will return NULL.
> >> Then hpriv->base = NULL - 0x20000; Kernel can run into
> >> a NULL-pointer dereference. This error check will avoid
> >> NULL pointer dereference.
> >>
> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> >
> > Applied to libata/for-4.10-fixes.
>
> Hold on, why not to convert to devm_ioremap_resource() ?
Care to send the patch?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap.
2017-01-08 18:49 ` Tejun Heo
@ 2017-01-08 22:08 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2017-01-08 22:08 UTC (permalink / raw)
To: Tejun Heo; +Cc: Arvind Yadav, linux-ide, linux-kernel@vger.kernel.org
On Sun, Jan 8, 2017 at 8:49 PM, Tejun Heo <tj@kernel.org> wrote:
> On Sat, Jan 07, 2017 at 12:52:57AM +0200, Andy Shevchenko wrote:
>> On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo <tj@kernel.org> wrote:
>> > On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote:
>> >> Here, If devm_ioremap will fail. It will return NULL.
>> >> Then hpriv->base = NULL - 0x20000; Kernel can run into
>> >> a NULL-pointer dereference. This error check will avoid
>> >> NULL pointer dereference.
>> >>
>> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> >
>> > Applied to libata/for-4.10-fixes.
>>
>> Hold on, why not to convert to devm_ioremap_resource() ?
>
> Care to send the patch?
Incremental or substitute?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-08 22:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-12 17:43 [V1] ata: sata_mv:- Handle return value of devm_ioremap Arvind Yadav
2017-01-06 20:46 ` Tejun Heo
2017-01-06 22:52 ` Andy Shevchenko
2017-01-08 18:49 ` Tejun Heo
2017-01-08 22:08 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox