From: Christoph Hellwig <hch@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libata-eh: Use switch() instead of sparse array for protocol strings
Date: Mon, 9 Jan 2017 09:22:07 -0800 [thread overview]
Message-ID: <20170109172207.GA10557@infradead.org> (raw)
In-Reply-To: <20170109162143.GA11959@infradead.org>
On Mon, Jan 09, 2017 at 08:21:43AM -0800, Christoph Hellwig wrote:
> Having it global is kinda weird anyway. But looking the code none
> of the commands actually using is in the paging path, so it could
> simply be replaced with a dynamic allocation in ata_scsi_rbuf_fill
> for the actually needed size, which often will be very small,
> or sometimes even 0.
Prototype here, only tested with a simple mkfs.xfs and some I/O on
AHCI so far:
http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/libata-kill-ata_scsi_rbuf
next prev parent reply other threads:[~2017-01-09 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 14:49 [PATCH] libata-eh: Use switch() instead of sparse array for protocol strings Geert Uytterhoeven
2017-01-09 15:23 ` Tejun Heo
2017-01-09 15:40 ` Geert Uytterhoeven
2017-01-09 16:04 ` Tejun Heo
2017-01-09 16:21 ` Christoph Hellwig
2017-01-09 17:22 ` Christoph Hellwig [this message]
2017-01-09 17:30 ` Tejun Heo
2017-01-09 16:30 ` Geert Uytterhoeven
2017-01-09 17:27 ` Christoph Hellwig
2017-01-09 17:31 ` Tejun Heo
2017-01-09 18:25 ` Geert Uytterhoeven
2017-01-09 19:41 ` Tejun Heo
2017-01-09 20:28 ` Geert Uytterhoeven
2017-01-09 20:31 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109172207.GA10557@infradead.org \
--to=hch@infradead.org \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox