From: Christoph Hellwig <hch@infradead.org>
To: tj@kernel.org
Cc: geert@linux-m68k.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 6/6] libata: switch to dynamic allocation insted of ata_scsi_rbuf
Date: Tue, 10 Jan 2017 06:40:54 -0800 [thread overview]
Message-ID: <20170110144054.GA22597@infradead.org> (raw)
In-Reply-To: <1484037708-654-7-git-send-email-hch@lst.de>
> struct scsi_cmnd *scmd = qc->scsicmd;
> struct scsi_device *sdp = scmd->device;
> - size_t len = sdp->sector_size;
> + ssize_t len = sdp->sector_size;
Julia Lawall's magic checker tool pointed out that len doesn't have
to change to ssize_t here, but the size variable should instead so that
we can properly handle the ENOMEM case below.
I'll wait for some more feedback on the patches and will eventually
resend with that fix.
next prev parent reply other threads:[~2017-01-10 14:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 8:41 libata: remove the global response buffer Christoph Hellwig
2017-01-10 8:41 ` [PATCH 1/6] libata: avoid global response buffer in atapi_qc_complete Christoph Hellwig
2017-01-10 8:41 ` [PATCH 2/6] libata: move struct ata_scsi_args to libata-scsi.c Christoph Hellwig
2017-01-10 8:41 ` [PATCH 3/6] libata: remove the done allback from ata_scsi_args Christoph Hellwig
2017-01-10 8:41 ` [PATCH 4/6] libata: call ->scsi_done from ata_scsi_simulate Christoph Hellwig
2017-01-10 8:41 ` [PATCH 5/6] libata: don't call ata_scsi_rbuf_fill for command without a response buffer Christoph Hellwig
2017-01-10 8:41 ` [PATCH 6/6] libata: switch to dynamic allocation insted of ata_scsi_rbuf Christoph Hellwig
2017-01-10 14:40 ` Christoph Hellwig [this message]
2017-01-10 15:56 ` libata: remove the global response buffer Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110144054.GA22597@infradead.org \
--to=hch@infradead.org \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox