From: Tejun Heo <tj@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: command emulation fix
Date: Wed, 18 Jan 2017 11:17:50 -0800 [thread overview]
Message-ID: <20170118191750.GA9171@mtj.duckdns.org> (raw)
In-Reply-To: <20170116152120.GA16072@lst.de>
Hello,
On Mon, Jan 16, 2017 at 04:21:20PM +0100, Christoph Hellwig wrote:
> On Sun, Jan 15, 2017 at 06:07:23PM -0500, Tejun Heo wrote:
> > Ugh... I don't know. What we had previously is always guaranteed to
> > work. I'm not really liking the fact that we're adding a possibility
> > of failure here. Even if we do mempool, we would still have to
> > protect it with a spinlock as mempool only guarantees one allocation
> > at a time. Until we have a better solution, can we please revert back
> > to where we were at least for the buffers needed from atomic context?
>
> In that case you'll need to drop all but the first patch from the series
> as ->queuecommand can always be called from atomic context.
I reverted just the last patch. The rest should be fine, right?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-01-18 19:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 16:50 command emulation fix Christoph Hellwig
2017-01-14 16:50 ` [PATCH] libata: switch allocations for command emulation to GFP_ATOMIC Christoph Hellwig
2017-01-15 23:07 ` command emulation fix Tejun Heo
2017-01-16 15:21 ` Christoph Hellwig
2017-01-18 19:17 ` Tejun Heo [this message]
2017-01-19 14:35 ` Christoph Hellwig
2017-01-19 20:23 ` Tejun Heo
2017-01-19 20:27 ` Christoph Hellwig
2017-01-19 20:34 ` Tejun Heo
2017-01-19 20:36 ` Tejun Heo
2017-01-19 20:41 ` Christoph Hellwig
2017-01-19 20:45 ` Tejun Heo
2017-01-19 20:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118191750.GA9171@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).