From: Christoph Hellwig <hch@lst.de>
To: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-ide@vger.kernel.org
Subject: Re: command emulation fix
Date: Thu, 19 Jan 2017 21:27:25 +0100 [thread overview]
Message-ID: <20170119202725.GB6403@lst.de> (raw)
In-Reply-To: <20170119202316.GA25390@mtj.duckdns.org>
On Thu, Jan 19, 2017 at 03:23:16PM -0500, Tejun Heo wrote:
> Yeah, it is probably fine but I just feel weird about changing the
> code to introduce a possible failure case. Let's leave it as-is for
> now.
We can move to a small mempool instead. If we ever want discards
(aka TRIM) to perform nicely on ATA a global static buffer isn't
going to cut it. I've spent some time to optimize it for NVMe so
that it's usable which I plan to submit soon. I've not looked ATA
in that respect yet, but it's probably going to be an issue.
next prev parent reply other threads:[~2017-01-19 20:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 16:50 command emulation fix Christoph Hellwig
2017-01-14 16:50 ` [PATCH] libata: switch allocations for command emulation to GFP_ATOMIC Christoph Hellwig
2017-01-15 23:07 ` command emulation fix Tejun Heo
2017-01-16 15:21 ` Christoph Hellwig
2017-01-18 19:17 ` Tejun Heo
2017-01-19 14:35 ` Christoph Hellwig
2017-01-19 20:23 ` Tejun Heo
2017-01-19 20:27 ` Christoph Hellwig [this message]
2017-01-19 20:34 ` Tejun Heo
2017-01-19 20:36 ` Tejun Heo
2017-01-19 20:41 ` Christoph Hellwig
2017-01-19 20:45 ` Tejun Heo
2017-01-19 20:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119202725.GB6403@lst.de \
--to=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).