Re: [PATCH] libata:pata_atiixp: Don't use unconnected secondary port on SB600/SB700

[Tejun Heo <tj@kernel.org>]

Hello, Darren.

On Fri, Jan 20, 2017 at 06:03:32PM +0000, Darren Stevens wrote:
> The SB600 and SB700 southbridge chips from ATI/AMD only have
> connections for the primary IDE port. As these chips have unique
> pci device ID's use these to mark the secondary port as 'dummy'
> 
> Signed-off-by: Darren Stevens <darren@stevens-zone.net>
> ---
> 
> diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c
> index 49d705c..588c473 100644
> --- a/drivers/ata/pata_atiixp.c
> +++ b/drivers/ata/pata_atiixp.c
> @@ -278,6 +278,11 @@ static int atiixp_init_one(struct pci_dev *pdev, const
> struct pci_device_id *id)
>     };
>     const struct ata_port_info *ppi[] = { &info, &info };
>  
> +   if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE) ||
        ^
	space here

> +       (pdev->device == PCI_DEVICE_ID_ATI_IXP700_IDE))
> +       /* SB600/700 don't have secondary port wired */

Can you move the comment above if?

> +       ppi[1] = &ata_dummy_port_info;
> +
>     return ata_pci_bmdma_init_one(pdev, ppi, &atiixp_sht, NULL,
>                       ATA_HOST_PARALLEL_SCAN);

And the patch is corrupt.  Attaching the formatted patch might work
better.

Thanks.

-- 
tejun