public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Darren Stevens <darren@stevens-zone.net>
Cc: tourula@gmail.com, linux-ide@vger.kernel.org
Subject: Re: pata_atiixp: Fix IDE detection on SB7xx
Date: Thu, 30 Mar 2017 11:51:57 -0400	[thread overview]
Message-ID: <20170330155157.GA22780@htj.duckdns.org> (raw)
In-Reply-To: <49d09a00a4e.6d8687b5@auth.smtp.1and1.co.uk>

Hello,

On Thu, Mar 30, 2017 at 10:08:52AM +0100, Darren Stevens wrote:
> What would you prefer the commit message to say? I was only explaining why the
> patch was needed.

Oh, I want it to explain why it matters to mark the unused port dummy.
It does reduce the probing time, right?

> I need to fix formatting anyway, as Sergei has pointed out, so either I rework
> this or you revert as originally planned and I'll resubmit the original patch
> for the SB600 only, whichever works best for you, I'm aware time is an issue
> here.

Can you please generate the patch on top of the following branch?

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git for-4.11-fixes

The revert was days ago, so I don't wanna replace it at this point.
Let's just do an incremnetal patch on top.

> I didn't include Markku as I'm not sure I should be adding people to the
> Commit without their express permission.

I see.  I sometimes try to get permission if the person only wrote off
list but once things are on the mailing list I don't think there's
anything to worry about.  Just cc them.

> I'm still quite new at this so sorry for causing all this trouble.

No worries.  You're doing great. :)

Thanks.

-- 
tejun

  reply	other threads:[~2017-03-30 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28 15:57 [PATCH] pata_atiixp: Fix IDE detection on SB7xx Darren Stevens
2017-03-28 17:00 ` Tejun Heo
2017-03-30  9:08   ` Darren Stevens
2017-03-30 15:51     ` Tejun Heo [this message]
2017-03-29 10:34 ` [PATCH] " Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170330155157.GA22780@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=darren@stevens-zone.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=tourula@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox