From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-block@vger.kernel.org
Subject: [PATCH 3/3] ide-pm: always pass 0 error to ide_complete_rq in ide_do_devset
Date: Wed, 26 Apr 2017 09:34:22 +0200 [thread overview]
Message-ID: <20170426073422.14511-4-hch@lst.de> (raw)
In-Reply-To: <20170426073422.14511-1-hch@lst.de>
The caller only looks at the scsi_request result field anyway.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/ide/ide-devsets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/ide-devsets.c b/drivers/ide/ide-devsets.c
index b1223234037d..9b69c32ee560 100644
--- a/drivers/ide/ide-devsets.c
+++ b/drivers/ide/ide-devsets.c
@@ -187,6 +187,6 @@ ide_startstop_t ide_do_devset(ide_drive_t *drive, struct request *rq)
err = setfunc(drive, *(int *)&scsi_req(rq)->cmd[1]);
if (err)
scsi_req(rq)->result = err;
- ide_complete_rq(drive, err, blk_rq_bytes(rq));
+ ide_complete_rq(drive, 0, blk_rq_bytes(rq));
return ide_stopped;
}
--
2.11.0
next prev parent reply other threads:[~2017-04-26 7:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 7:34 three little req->errors follow ups Christoph Hellwig
2017-04-26 7:34 ` [PATCH 1/3] scsi_transport_sas: always pass 0 error to blk_end_request_all Christoph Hellwig
2017-04-26 7:34 ` [PATCH 2/3] ide-pm: always pass 0 error to __blk_end_request_all Christoph Hellwig
2017-04-26 10:32 ` Bartlomiej Zolnierkiewicz
2017-04-26 14:39 ` David Miller
2017-04-26 7:34 ` Christoph Hellwig [this message]
2017-04-26 10:33 ` [PATCH 3/3] ide-pm: always pass 0 error to ide_complete_rq in ide_do_devset Bartlomiej Zolnierkiewicz
2017-04-26 14:39 ` David Miller
2017-04-26 13:54 ` three little req->errors follow ups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426073422.14511-4-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox