From: Tejun Heo <tj@kernel.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-ide@vger.kernel.org,
Gregory Clement <gregory.clement@free-electrons.com>
Subject: Re: [PATCH] ata: libahci: properly propagate return value of platform_get_irq()
Date: Tue, 16 May 2017 11:20:22 -0400 [thread overview]
Message-ID: <20170516152022.GA6389@htj.duckdns.org> (raw)
In-Reply-To: <1494936372-27209-1-git-send-email-thomas.petazzoni@free-electrons.com>
On Tue, May 16, 2017 at 02:06:12PM +0200, Thomas Petazzoni wrote:
> When platform_get_irq() fails, it returns an error code, which
> libahci_platform and replaces it by -EINVAL. This commit fixes that by
> propagating the error code. It fixes the situation where
> platform_get_irq() returns -EPROBE_DEFER because the interrupt
> controller is not available yet, and generally looks like the right
> thing to do.
>
> We pay attention to not show the "no irq" message when we are in an
> EPROBE_DEFER situation, because the driver probing will be retried
> later on, once the interrupt controller becomes available to provide
> the interrupt.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Applied to libata/for-4.12-fixes.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-05-16 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 12:06 [PATCH] ata: libahci: properly propagate return value of platform_get_irq() Thomas Petazzoni
2017-05-16 12:59 ` Hans de Goede
2017-05-16 15:20 ` Tejun Heo [this message]
2017-05-17 9:11 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516152022.GA6389@htj.duckdns.org \
--to=tj@kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox