From: Tejun Heo <tj@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-ide@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] libata: Fix devres handling
Date: Tue, 23 May 2017 17:27:36 -0400 [thread overview]
Message-ID: <20170523212736.GL13222@htj.duckdns.org> (raw)
In-Reply-To: <20170523211608.GJ13222@htj.duckdns.org>
Hello, again.
On Tue, May 23, 2017 at 05:16:08PM -0400, Tejun Heo wrote:
> That's 96 bytes of difference, which seems too big for devres_node,
> especially on 32bit machines. Can you check what gdb says on "print
> ((struct devres *)0)->data" or "print sizeof(struct devres_node)"?
>
> There gotta be something else going on. devres_alloc() returns the
> data pointer which is the same one which gets passed into the release
> function.
Also, can you please add throw in some printks and see what's being
returned from devres_alloc() and getting set on driver data? This is
really weird. I can't think of a reason why they'd differ.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-05-23 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 23:03 [PATCH] libata: Fix devres handling Linus Walleij
2017-05-23 21:16 ` Tejun Heo
2017-05-23 21:27 ` Tejun Heo [this message]
2017-05-30 9:21 ` Linus Walleij
2017-05-30 17:59 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523212736.GL13222@htj.duckdns.org \
--to=tj@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox