Re: [PATCH 6/6] sd: add support for TCG OPAL self encrypting disks

Christoph Hellwig
2017-06-13T06:40:18Z

On Tue, Jun 06, 2017 at 11:58:02AM +0200, Christoph Hellwig wrote:
> On Mon, Jun 05, 2017 at 08:48:00PM -0400, Martin K. Petersen wrote:
> > For WRITE SAME, scsi_report_opcode() is gated not only by
> > sdev->no_report_opcodes but by sdev->no_write_same.
> >
> > I'm concerned about firing off REPORT OPCODES to random devices without
> > a sufficiently good heuristic. Doesn't look like SAT has anything to
> > offer in this department, though. Maybe it's time to consider a
> > vendor-specific Linux VPD page...
>
> Eww. Given that as far as I can tell only ATA devices implement
> OPAL we could key it off that for now. But that's only going to
> defer the problem until support for other security protocols comes
> along for real SCSI devices.
>
> But as we already set no_report_opcodes for all usb-storage and
> quirked uas devices I think the worst offenders are already covered
> anyway.

Martin, how do we want to move ahead on this patch?