* [PATCH] ata: ftide010: fix resource printing
@ 2017-06-21 22:00 Arnd Bergmann
2017-06-21 22:06 ` Tejun Heo
2017-06-25 22:07 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-06-21 22:00 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Tejun Heo, Linus Walleij
Cc: Arnd Bergmann, Hans Ulli Kroll, linux-ide, linux-kernel
The new driver uses an incorrect format string for resource_size_t:
drivers/ata/pata_ftide010.c: In function 'pata_ftide010_probe':
drivers/ata/pata_ftide010.c:520:17: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
The nicest way to print the address is to pretty-print the resource
using %pR.
Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/ata/pata_ftide010.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_ftide010.c b/drivers/ata/pata_ftide010.c
index 7b7e417ba8ba..5d4b72e21161 100644
--- a/drivers/ata/pata_ftide010.c
+++ b/drivers/ata/pata_ftide010.c
@@ -517,8 +517,8 @@ static int pata_ftide010_probe(struct platform_device *pdev)
ata_sff_std_ports(ioaddr);
}
- dev_info(dev, "device ID %08x, irq %d, io base 0x%08x\n",
- readl(ftide->base + FTIDE010_IDE_DEVICE_ID), irq, res->start);
+ dev_info(dev, "device ID %08x, irq %d, reg %pR\n",
+ readl(ftide->base + FTIDE010_IDE_DEVICE_ID), irq, res);
ret = ata_host_activate(ftide->host, irq, ata_bmdma_interrupt,
0, &pata_ftide010_sht);
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ata: ftide010: fix resource printing
2017-06-21 22:00 [PATCH] ata: ftide010: fix resource printing Arnd Bergmann
@ 2017-06-21 22:06 ` Tejun Heo
2017-06-25 22:07 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2017-06-21 22:06 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bartlomiej Zolnierkiewicz, Linus Walleij, Hans Ulli Kroll,
linux-ide, linux-kernel
On Thu, Jun 22, 2017 at 12:00:55AM +0200, Arnd Bergmann wrote:
> The new driver uses an incorrect format string for resource_size_t:
>
> drivers/ata/pata_ftide010.c: In function 'pata_ftide010_probe':
> drivers/ata/pata_ftide010.c:520:17: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>
> The nicest way to print the address is to pretty-print the resource
> using %pR.
>
> Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to libata/for-4.13.
Thanks.
--
Tejun
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ata: ftide010: fix resource printing
2017-06-21 22:00 [PATCH] ata: ftide010: fix resource printing Arnd Bergmann
2017-06-21 22:06 ` Tejun Heo
@ 2017-06-25 22:07 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-06-25 22:07 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bartlomiej Zolnierkiewicz, Tejun Heo, Hans Ulli Kroll, linux-ide,
linux-kernel@vger.kernel.org
On Thu, Jun 22, 2017 at 12:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The new driver uses an incorrect format string for resource_size_t:
>
> drivers/ata/pata_ftide010.c: In function 'pata_ftide010_probe':
> drivers/ata/pata_ftide010.c:520:17: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>
> The nicest way to print the address is to pretty-print the resource
> using %pR.
>
> Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-25 22:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-21 22:00 [PATCH] ata: ftide010: fix resource printing Arnd Bergmann
2017-06-21 22:06 ` Tejun Heo
2017-06-25 22:07 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox