From: Tejun Heo <tj@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()
Date: Fri, 30 Jun 2017 08:01:06 -0400 [thread overview]
Message-ID: <20170630120106.GB16820@htj.duckdns.org> (raw)
In-Reply-To: <e71b065e-554e-4dee-06cc-b1cea6b3de53@cogentembedded.com>
On Fri, Jun 30, 2017 at 12:42:38PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote:
>
> > Print error message and propagate the return value of
> > platform_get_irq on failure.
>
> You should have probably mentioned that this function no longer returns 0
> on error.
Yeah, the patches looks good to me but I'd really appreciate more
context in the changelogs. Gustavo, can you please respin the
patches?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-06-30 12:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 5:22 [PATCH] sata_rcar: fix error return code in sata_rcar_probe() Gustavo A. R. Silva
2017-06-30 9:42 ` Sergei Shtylyov
2017-06-30 12:01 ` Tejun Heo [this message]
2017-06-30 19:36 ` Gustavo A. R. Silva
2017-06-30 19:42 ` Sergei Shtylyov
2017-06-30 19:54 ` Gustavo A. R. Silva
2017-06-30 19:46 ` Gustavo A. R. Silva
2017-06-30 20:03 ` Sergei Shtylyov
2017-06-30 20:34 ` Gustavo A. R. Silva
2017-06-30 21:08 ` [PATCH v2] " Gustavo A. R. Silva
2017-06-30 21:09 ` Sergei Shtylyov
2017-06-30 21:11 ` Gustavo A. R. Silva
2017-06-30 12:35 ` [PATCH] " Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630120106.GB16820@htj.duckdns.org \
--to=tj@kernel.org \
--cc=garsilva@embeddedor.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox