From: Tejun Heo <tj@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sathya Prakash <sathya.prakash@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
the arch/x86 maintainers <x86@kernel.org>,
xen-devel <xen-devel@lists.xenproject.org>,
linux-block <linux-block@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
IDE-ML <linux-ide@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>
Subject: Re: Lots of new warnings with gcc-7.1.1
Date: Sat, 15 Jul 2017 07:03:16 -0400 [thread overview]
Message-ID: <20170715110316.GD2969123@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <CAK8P3a2itguODKUNtw8m-7RReUkyEqk8fHYRLa-ZjJYjwwhYdg@mail.gmail.com>
Hello,
On Wed, Jul 12, 2017 at 03:31:02PM +0200, Arnd Bergmann wrote:
> > We also have about a bazillion
> >
> > warning: ‘*’ in boolean context, suggest ‘&&’ instead
> >
> > warnings in drivers/ata/libata-core.c, all due to a single macro that
> > uses a pattern that gcc-7.1.1 doesn't like. The warning looks a bit
> > debatable, but I suspect the macro could easily be changed too.
> >
> > Tejun, would you hate just moving the "multiply by 1000" part _into_
> > that EZ() macro? Something like the attached (UNTESTED!) patch?
>
> Tejun applied an almost identical patch of mine a while ago, but it seems to
> have gotten lost in the meantime in some rebase:
Yeah, I was scratching my head remembering your patch. Sorry about
that. It should have been routed through for-4.12-fixes.
> https://patchwork.kernel.org/patch/9721397/
> https://patchwork.kernel.org/patch/9721399/
>
> I guess I should have resubmitted the second patch with the suggested
> improvement.
The new one looks good to me.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-07-15 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 22:35 Lots of new warnings with gcc-7.1.1 Linus Torvalds
2017-07-11 23:54 ` Marcel Holtmann
2017-07-12 3:10 ` Guenter Roeck
2017-07-12 3:17 ` Linus Torvalds
2017-07-12 3:41 ` Linus Torvalds
2017-07-12 13:31 ` Arnd Bergmann
2017-07-15 11:03 ` Tejun Heo [this message]
2017-07-12 4:19 ` Jakub Kicinski
2017-07-12 12:37 ` Mauro Carvalho Chehab
2017-07-12 13:10 ` Greg Kroah-Hartman
2017-07-12 13:51 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170715110316.GD2969123@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox