From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: Lots of new warnings with gcc-7.1.1 Date: Sat, 15 Jul 2017 07:03:16 -0400 Message-ID: <20170715110316.GD2969123@devbig577.frc2.facebook.com> References: <848b3f21-9516-8a66-e4b3-9056ce38d6f6@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org To: Arnd Bergmann Cc: Linus Torvalds , Guenter Roeck , Jean Delvare , Bartlomiej Zolnierkiewicz , Sathya Prakash , "James E.J. Bottomley" , Greg Kroah-Hartman , the arch/x86 maintainers , xen-devel , linux-block , Linux Media Mailing List , IDE-ML , "linux-fbdev@vger.kernel.org" , Network Development List-Id: linux-ide@vger.kernel.org Hello, On Wed, Jul 12, 2017 at 03:31:02PM +0200, Arnd Bergmann wrote: > > We also have about a bazillion > > > > warning: ‘*’ in boolean context, suggest ‘&&’ instead > > > > warnings in drivers/ata/libata-core.c, all due to a single macro that > > uses a pattern that gcc-7.1.1 doesn't like. The warning looks a bit > > debatable, but I suspect the macro could easily be changed too. > > > > Tejun, would you hate just moving the "multiply by 1000" part _into_ > > that EZ() macro? Something like the attached (UNTESTED!) patch? > > Tejun applied an almost identical patch of mine a while ago, but it seems to > have gotten lost in the meantime in some rebase: Yeah, I was scratching my head remembering your patch. Sorry about that. It should have been routed through for-4.12-fixes. > https://patchwork.kernel.org/patch/9721397/ > https://patchwork.kernel.org/patch/9721399/ > > I guess I should have resubmitted the second patch with the suggested > improvement. The new one looks good to me. Thanks. -- tejun