From: Tejun Heo <tj@kernel.org>
To: Taras Kondratiuk <takondra@cisco.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
xe-linux-external@cisco.com
Subject: Re: Manual unbind of ATA devices causes use-after-free
Date: Fri, 3 Nov 2017 06:19:37 -0700 [thread overview]
Message-ID: <20171103131937.GQ3252168@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <150957868766.7160.13267337838101258462@takondra-t460s>
Hello,
On Wed, Nov 01, 2017 at 04:24:47PM -0700, Taras Kondratiuk wrote:
> Manual unbind/remove unconditionally invokes devres_release_all which
> calls ata_host_release() and frees ata_host/ata_port memory while it is
> still being referenced (e.g as a parent of SCSI host).
>
> Is there a reason why ata_host is using derves which is not refcounted?
> Does it make sense to add recounting to ata_host?
Hmm... the removal path is supposed to drain everything synchronously.
What kind of controller is it?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-11-03 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 23:24 Manual unbind of ATA devices causes use-after-free Taras Kondratiuk
2017-11-03 13:19 ` Tejun Heo [this message]
2017-11-03 16:32 ` Taras Kondratiuk
2017-11-06 15:24 ` Tejun Heo
2017-11-13 20:09 ` Taras Kondratiuk
2017-11-13 20:10 ` Tejun Heo
2018-03-09 8:34 ` [PATCH] libata: add refcounting to ata_host Taras Kondratiuk
2018-03-13 20:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103131937.GQ3252168@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=takondra@cisco.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox