From: Tejun Heo <tj@kernel.org>
To: Martyn Welch <martyn.welch@collabora.co.uk>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Egor Starkov <egor.starkov@ge.com>
Subject: Re: [PATCH v2] ahci: imx: Handle increased read failures for IMX53 temperature sensor in low frequency mode.
Date: Mon, 13 Nov 2017 12:18:02 -0800 [thread overview]
Message-ID: <20171113201802.GO983427@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1510569061-28993-1-git-send-email-martyn.welch@collabora.co.uk>
On Mon, Nov 13, 2017 at 10:31:01AM +0000, Martyn Welch wrote:
> From: Egor Starkov <egor.starkov@ge.com>
>
> Extended testing has shown that the imx ahci driver sometimes requires
> more than the 100 attempts currently alotted in the driver to perform a
> successful temperature reading when running at minimum (throttled) CPU
> frequency.
>
> Debugging suggests that the read cycle can take 160 attempts (which given
> that the driver averages 80 readings from the ADC equates to one failure
> on each read).
>
> Increase the attempt limit to 200 in order to greatly reduce the
> likelihood of the driver failing to perform a temperature reading,
> especially at low CPU frequency.
>
> Signed-off-by: Egor Starkov <egor.starkov@ge.com>
> Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>
Applied to libata/for-4.15.
Thanks.
--
tejun
prev parent reply other threads:[~2017-11-13 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 10:31 [PATCH v2] ahci: imx: Handle increased read failures for IMX53 temperature sensor in low frequency mode Martyn Welch
2017-11-13 20:18 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113201802.GO983427@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=egor.starkov@ge.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox