From: Tejun Heo <tj@kernel.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH v2] pata_pdc2027x: Fix coding sytle errors
Date: Tue, 5 Dec 2017 11:49:48 -0800 [thread overview]
Message-ID: <20171205194948.GY2421075@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1512498399-23577-1-git-send-email-arvind.yadav.cs@gmail.com>
On Tue, Dec 05, 2017 at 11:56:38PM +0530, Arvind Yadav wrote:
> Fix these checkpatch.pl errors:
> Fix checkpatch.pl error:
> ERROR: space prohibited before open square bracket '['.
>
> ERROR: space prohibited after that '~' (ctx:WxW)
> + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA));
>
> ERROR: spaces required around that '?' (ctx:VxW)
> + long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
>
> ERROR: that open brace { should be on the previous line
> + const struct ata_port_info *ppi[] =
> + { &pdc2027x_port_info[board_idx], NULL };
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch doesn't apply to libata/for-4.16. Also, please keep Bart's
Acked-by when posting updated versions.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-12-05 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 18:26 [PATCH v2] pata_pdc2027x: Fix coding sytle errors Arvind Yadav
2017-12-05 19:49 ` Tejun Heo [this message]
2017-12-06 9:43 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205194948.GY2421075@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox