From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: about warning in ata_eh_finish() Date: Wed, 20 Dec 2017 09:36:36 -0800 Message-ID: <20171220173636.GC3413940@devbig577.frc2.facebook.com> References: <5A39FF85.1040904@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-qk0-f172.google.com ([209.85.220.172]:43288 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755885AbdLTRgk (ORCPT ); Wed, 20 Dec 2017 12:36:40 -0500 Received: by mail-qk0-f172.google.com with SMTP id j137so9839924qke.10 for ; Wed, 20 Dec 2017 09:36:40 -0800 (PST) Content-Disposition: inline In-Reply-To: <5A39FF85.1040904@huawei.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jason Yan Cc: linux-ide@vger.kernel.org On Wed, Dec 20, 2017 at 02:13:25PM +0800, Jason Yan wrote: > Hi, Tejun, > > We often see this warning when using sata disks with libsas: > > [26705.760518] WARNING: CPU: 1 PID: 6796 at > drivers/ata/libata-eh.c:4037 ata_eh_finish+0xb4/0xcc > > [26706.350156] [] ata_eh_finish+0xb4/0xcc > [26706.364260] [] ata_do_eh+0x68/0xd8 > [26706.377497] [] ata_std_error_handler+0x44/0x8c > [26706.393406] [] ata_scsi_port_error_handler+0x480/0x694 > [26706.411352] [] async_sas_ata_eh+0x4c/0x80 > [26706.426133] [] async_run_entry_fn+0x4c/0x170 > [26706.441841] [] process_one_work+0x144/0x390 > [26706.457057] [] worker_thread+0x144/0x418 > [26706.471610] [] kthread+0x10c/0x138 > [26706.484991] [] ret_from_fork+0x10/0x18 > > This seems implies that ap->nr_active_links is wrong and should be zero. > But I didn't see any other errors. The disks work well. Which kernel version are you running on what sort of device? Can you post the full log? Thanks. -- tejun