public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: ahci_brcm: Avoid clobbering SATA_TOP_CTRL_BUS_CTRL
Date: Tue, 2 Jan 2018 08:38:43 -0800	[thread overview]
Message-ID: <20180102163843.GG3668920@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20171222194331.6330-1-f.fainelli@gmail.com>

On Fri, Dec 22, 2017 at 11:43:08AM -0800, Florian Fainelli wrote:
> We are doing a blind write to SATA_TOP_CTRL_BUS_CTRL to set the system
> endian, but in doing so, we are also overwriting other bits, such as the
> SATA_SCB_BURST_SIZE and SATA_FIFO_SIZE bits, which impact performance.
> Do a read/modify/write so we keep the default values.
> 
> While we are at it, we also greatly simplify the logic and just leave
> the NSP specific bit settings, instead of having a completely different
> sequence.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied to libata/for-4.16.

Thanks.

-- 
tejun

      reply	other threads:[~2018-01-02 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-22 19:43 [PATCH] ata: ahci_brcm: Avoid clobbering SATA_TOP_CTRL_BUS_CTRL Florian Fainelli
2018-01-02 16:38 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180102163843.GG3668920@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox