From: Tejun Heo <tj@kernel.org>
To: Darren Stevens <darren@stevens-zone.net>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata:pata_atiixp: Don't use unconnected secondary port on SB600
Date: Mon, 8 Jan 2018 04:02:38 -0800 [thread overview]
Message-ID: <20180108120238.GI3668920@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <4b3d1364126.4c1d107e@auth.smtp.1and1.co.uk>
On Sun, Dec 31, 2017 at 09:11:05PM +0000, Darren Stevens wrote:
> The AMD SB600 southbridge has an PATA IDE interface, but the
> secondary port has no physical connections, so is disabled in
> the PCI header which makes it appear as a legacy port.
>
> On most systems this causes no trouble, but the Amigaone X1000 has
> an SB600 connected to a PowerPC SoC PCI-e root port, with an
> emulated ISA bus. On this system a kernel panic occurs at boot
> time during device attach for the secondary port.
>
> Mark the port as 'dummy' to prevent this. As a bonus, disabling
> this will slightly speed up booting on PC systems using an
> SB600 as they will now skip 2 known empty ports.
>
> Signed-off-by: Darren Stevens <Darren@stevens-zone.net>
Applied to libata/for-4.16.
Thanks.
--
tejun
prev parent reply other threads:[~2018-01-08 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 21:11 [PATCH] libata:pata_atiixp: Don't use unconnected secondary port on SB600 Darren Stevens
2018-01-02 14:56 ` Tejun Heo
2018-01-06 10:13 ` Darren Stevens
2018-01-08 12:02 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108120238.GI3668920@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=darren@stevens-zone.net \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).