From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/2] ahci: Use usleep_range() in ahci_start_port()
Date: Thu, 11 Jan 2018 20:22:02 +0200 [thread overview]
Message-ID: <20180111182202.GS27654@lahna.fi.intel.com> (raw)
In-Reply-To: <20180111181117.GL3460072@devbig577.frc2.facebook.com>
On Thu, Jan 11, 2018 at 10:11:17AM -0800, Tejun Heo wrote:
> On Thu, Jan 11, 2018 at 03:55:51PM +0300, Mika Westerberg wrote:
> > Using msleep(1) may actually sleep much longer than 1 msecs (~20 msecs)
> > which unnecessarily slows down system startup. Avoid that and use
> > usleep_range() instead.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Heh, I'm not sure. How big of a problem is this?
It's not a big problem so you may ignore the patch if you think it is
not needed. I just noticed the msleep(1) there and though we could do
better using usleep_range().
next prev parent reply other threads:[~2018-01-11 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 12:55 [PATCH 1/2] ahci: Add Intel Cannon Lake PCH-H PCI ID Mika Westerberg
2018-01-11 12:55 ` [PATCH 2/2] ahci: Use usleep_range() in ahci_start_port() Mika Westerberg
2018-01-11 18:11 ` Tejun Heo
2018-01-11 18:22 ` Mika Westerberg [this message]
2018-01-11 18:10 ` [PATCH 1/2] ahci: Add Intel Cannon Lake PCH-H PCI ID Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111182202.GS27654@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox