From: Tejun Heo <tj@kernel.org>
To: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Michael Schmitz <schmitzmic@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver
Date: Mon, 19 Mar 2018 07:41:01 -0700 [thread overview]
Message-ID: <20180319144101.GH2943022@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <CAOFm3uEb6r33V9=Maxd72pM6vdwfMkvhap01+zEd6bnDuEAVKw@mail.gmail.com>
Hello,
On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote:
> > v2:
> > - clarify license version (it should be GPL 2.0)
> > - use SPDX header
>
> For the use of SPDX ids, you have my ack: (I am not qualified for the rest)
>
> Acked-by: Philippe Ombredanne <pombredanne@nexb.com>
I don't think it's a good idea to add this acked-by when it's purely
based on a single liner license tag. I understand that you want to
encourage use of the new tags but this can be misleading and it'd be
great if you reconsider sending out acks like this.
Thanks.
--
tejun
next prev parent reply other threads:[~2018-03-19 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180316161549epcas1p23166605ea9922198486e0c07bd184ed8@epcas1p2.samsung.com>
2018-03-16 16:15 ` [PATCH v3] ata: add Amiga Gayle PATA controller driver Bartlomiej Zolnierkiewicz
2018-03-18 5:24 ` Philippe Ombredanne
2018-03-19 14:41 ` Tejun Heo [this message]
2018-03-23 17:10 ` Philippe Ombredanne
2018-03-19 14:42 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319144101.GH2943022@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=pombredanne@nexb.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox