* [PATCH] ide-tape: remove redundant variable buffer_size
@ 2018-07-02 10:00 Colin King
2018-08-13 18:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-07-02 10:00 UTC (permalink / raw)
To: David S . Miller, linux-ide; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable buffer_size is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'buffer_size' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/ide/ide-tape.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index aee7b46d2330..34c1165226a4 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -1746,7 +1746,6 @@ static void idetape_setup(ide_drive_t *drive, idetape_tape_t *tape, int minor)
{
unsigned long t;
int speed;
- int buffer_size;
u16 *ctl = (u16 *)&tape->caps[12];
ide_debug_log(IDE_DBG_FUNC, "minor: %d", minor);
@@ -1781,7 +1780,6 @@ static void idetape_setup(ide_drive_t *drive, idetape_tape_t *tape, int minor)
*ctl /= 2;
tape->buffer_size = *ctl * tape->blk_size;
}
- buffer_size = tape->buffer_size;
/* select the "best" DSC read/write polling freq */
speed = max(*(u16 *)&tape->caps[14], *(u16 *)&tape->caps[8]);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ide-tape: remove redundant variable buffer_size
2018-07-02 10:00 [PATCH] ide-tape: remove redundant variable buffer_size Colin King
@ 2018-08-13 18:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-08-13 18:50 UTC (permalink / raw)
To: colin.king; +Cc: linux-ide, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Mon, 2 Jul 2018 11:00:26 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable buffer_size is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'buffer_size' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-13 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-02 10:00 [PATCH] ide-tape: remove redundant variable buffer_size Colin King
2018-08-13 18:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).